求助数据储存优化及代码优化（用户登录模块）

Cleanhun

PS：该程序有一默认锁定的用户（即所读取的文件均不为空）
源代码如下：

1. import easygui as g
   
2. 
   
3. def count_users():
   
4.     count = len(dict_members)
   
5.     return count
   
6. 
   
7. def secure_question(read_write):
   
8.     if read_write == 'read':
   
9.         with open('securequestions.pkl','rb') as read_file:
   
10.             (questions,answer) = pickle.load(read_file)
    
11.             return (questions,answer)
    
12.         
    
13.     if read_write == 'write':
    
14.         (list_question,list_answer) = secure_question('read')
    
15.         msg = '请设置账号密保问题'
    
16.         title = '账号安全设置'
    
17.         choices = ('密保问题','答案')
    
18.         while True:
    
19.             (str_question,str_answer) = g.multenterbox(msg,title,choices)
    
20.             if len(str_question) and len(str_answer):
    
21.                 break
    
22.             else:
    
23.                 msg = '输入不能为空，请重新输入'
    
24.         list_question.append(str_question)
    
25.         list_answer.append(str_answer)
    
26.         question_data = [list_question,list_answer]
    
27.         with open('securequestions.pkl','wb') as write_file:
    
28.             pickle.dump(question_data,write_file)
    
29.         g.msgbox('密保问题设置成功','安全通知')
    
30.         
    
31.         
    
32.    
    
33. def read_user_ID(file_name):
    
34.     pickle_file = open(file_name,'rb')
    
35.     dict_user = pickle.load(pickle_file)
    
36.     pickle_file.close()
    
37.     return dict_user
    
38. 
    
39. def read_password():
    
40.     with open('password.pkl','rb') as passwd_file:
    
41.         passwd = pickle.load(passwd_file)
    
42.         return passwd
    
43. 
    
44. def write_password(password):
    
45.     passwd = read_password()
    
46.     passwd.append(password)
    
47.         
    
48.     with open('password.pkl','wb') as passwd_file:
    
49.         pickle.dump(passwd,passwd_file)
    
50.         
    
51.         
    
52. 
    
53. def write_file(name,user_ID):
    
54.     dict_members[name] = user_ID
    
55.     pickle_file = open('data.pkl','wb')
    
56.     pickle.dump(dict_members,pickle_file)
    
57.     pickle_file.close()
    
58. 
    
59. 
    
60. def changepasswd(name):
    
61.     (question,answer) = secure_question('read')
    
62.     flag = dict_members[name]
    
63.     msg = question[flag]
    
64.     correct_answer = answer[flag]
    
65.     title = '修改密码窗口'
    
66.     while True:
    
67.         enter_answer = g.enterbox(msg,title)
    
68.         if enter_answer == correct_answer:
    
69.             msg = '请输入新密码'
    
70.             new_password = g.passwordbox(msg,title)
    
71.             password_list = read_password()
    
72.             password_list[flag] = new_password
    
73.             with open('password.pkl','wb') as passwd_file:
    
74.                 pickle.dump(password_list,passwd_file)
    
75.             break
    
76.         else:
    
77.             msg = question[flag]
    
78.             msg = '输入错误，请重新输入'+'\n'+msg
    
79. 
    
80. def find_password():
    
81.     msg = '请输入您的用户名'
    
82.     title = '找回密码'
    
83.     name = g.enterbox(msg,title)
    
84.     if name in dict_members:
    
85.         changepasswd(name)
    
86.     else: g.msgbox('您输入的用户名不存在','提示')
    
87.         
    
88.    
    
89.    
    
90. def main_menu():
    
91.     title = '主界面'
    
92.     choices = ('修改密码','注销','退出')
    
93.     while True:
    
94.         option = g.buttonbox('',title,choices)
    
95.         if option == '修改密码':
    
96.             changepasswd(current_user)
    
97.         if option == '注销':
    
98.             return False
    
99.         if option == '退出':
    
100.             return True
     
101. 
     
102. def frozen_users(read_write,name):
     
103.     if read_write == 'read':
     
104.         with open('frozen.pkl','rb') as frozend_file:
     
105.             frozen_user = pickle.load(frozend_file)
     
106.             return frozen_user
     
107. 
     
108.     if  read_write == 'write':
     
109.         Name = name
     
110.         frozen_list = frozen_users('read',Name)
     
111.         frozen_list.append(name)
     
112.         with open('frozen.pkl','wb') as frozen_file:
     
113.             pickle.dump(frozen_list,frozen_file)
     
114. 
     
115. 
     
116. def frozen_off(name):
     
117.     user_ID = dict_members[name]
     
118.     (questions,answer) = secure_question('read')
     
119.     msg = questions[user_ID]
     
120.     title = '账号安全窗口'
     
121.     n = 3
     
122.     while n:
     
123.         answer_enter = g.enterbox(msg,title)
     
124.         if answer_enter == answer[user_ID]:
     
125.             frozen_list = frozen_users('read',name)
     
126.             frozen_list.remove(name)
     
127.             with open('frozen.pkl','wb') as frozen_file:
     
128.                 pickle.dump(frozen_list,frozen_file)
     
129.             break
     
130.         else:
     
131.             n -= 1
     
132.             g.msgbox('输入错误，你还有%d次机会'%n,title)
     
133.             
     
134. 
     
135. def SignIn():
     
136.     msg = '请输入用户名和密码'
     
137.     title = '用户注册窗口'
     
138.     user_info = []
     
139.     user_info = g.multpasswordbox(msg,title,('用户名','密码'))
     
140.     (name,password) = user_info
     
141.     while name in dict_members:
     
142.         g.msgbox('用户名已存在请重新输入！')
     
143.         SignIn()
     
144.     else:
     
145.         user_ID = count_users()
     
146.         dict_members[name] = user_ID
     
147.         
     
148.         write_password(password)
     
149.         write_file(name,user_ID)
     
150.         secure_question('write')
     
151.         return { name:user_ID }
     
152. 
     
153. def login(msg,title):
     
154.     while 1:
     
155.         user_info = []
     
156.         user_info = g.multpasswordbox(msg,title,('用户名','密码'))
     
157.         (name,password) = user_info
     
158. 
     
159.         if name not in dict_members:
     
160.             g.msgbox('用户名不存在请重新输入！')
     
161.             login(msg,title)
     
162.         else:
     
163.             break
     
164.     return user_info
     
165. 
     
166. 
     
167. def LogIn():
     
168.    
     
169.     msg = '请输入用户名和密码'
     
170.     title = '用户登录窗口'
     
171.     (Name,Password) = login(msg,title)
     
172.     if Name in frozen_users('read',Name):
     
173.         g.msgbox('该用户已冻结，请前往解冻')
     
174.         frozen_off(Name)
     
175.     else:
     
176.          global current_user
     
177.          current_user = Name
     
178.          user_ID = dict_members[Name]
     
179.          passwd = read_password()
     
180.          n = 3
     
181.          while (n-1):
     
182.             if Password == passwd[user_ID]:
     
183.                
     
184.                 # (暂时不用) g.msgbox('欢迎进入XXOO系统，请点击右上角的X结束程序',ok_button = '退出')
     
185.                 return True
     
186.                 break
     
187.             else:
     
188.                 n -= 1
     
189.                 msg = '密码输入错误，你还有%d次机会' % n
     
190.                 (Name,Password) = login(msg,title)
     
191.          else:
     
192.             g.msgbox('已输错三次密码，账号已锁定')
     
193.             frozen_users('write',Name)
     
194.             frozen_off(Name)
     
195.         
     
196.    
     
197. 
     
198. import pickle
     
199. 
     
200. dict_members = read_user_ID('data.pkl')
     
201. cmd = True
     
202. while cmd:
     
203.     title = '请选择操作对象'
     
204.     choices = ('注册','登录','忘记密码','退出')
     
205.     temp = g.buttonbox('',title,choices)
     
206. 
     
207.     if temp == '注册':
     
208.         newmember = SignIn()
     
209.         dict_members.update(newmember)
     
210.         g.msgbox('注册成功，赶紧登陆试试吧~')
     
211.         
     
212.     elif temp == '登录' :
     
213.         while LogIn():
     
214.             cmd = main_menu()
     
215.             if cmd:
     
216.                 break
     
217. 
     
218.     elif temp == '忘记密码':
     
219.         find_password()
     
220. 
     
221.     elif temp == '退出' :
     
222.         break
     
223.         
     
224. g.msgbox('欢迎使用本程序',ok_button = '再见')
     
225.             
     
226.         
     
227. 
     
228. 
     
229.         
     
230.         
     
231. 
     
232.         
     
233.    
     

复制代码

Twilight6

先提个最基本的优化，你运行程序前先检测有无data.pkl文件，若无就新建，否则读取

Cleanhun

Twilight6 发表于 2020-7-3 21:16
先提个最基本的优化，你运行程序前先检测有无data.pkl文件，若无就新建，否则读取

谢谢，会加进去的